feat(drag-drop): add support for sorting animations #12530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
jelbourn
reviewed
Aug 6, 2018
| this.entered.emit({item, container: this}); | ||
| this.start(); | ||
|
|
||
| const newIndex = this._getItemIndexFromPointerPosition(item, xOffset, yOffset); |
There was a problem hiding this comment.
Add a comment here that's something like...
// We use the coordinates of where the item entered the drop container in order to ...| // We need to clone the `clientRect` here, because all the values on it are readonly | ||
| // and we need to be able to update them. Also we can't use a spread here, because | ||
| // the values on a `ClientRect` aren't own properties. See: | ||
| // https://developer.mozilla.org/en-US/docs/Web/API/Element/getBoundingClientRect#Notes |
| @@ -227,7 +299,47 @@ export class CdkDrop<T = any> implements OnInit, OnDestroy { | |||
| /** Resets the container to its initial state. */ | |||
| private _reset() { | |||
| this._dragging = false; | |||
|
|
|||
| // TODO: may have to wait for the animations to finish. | |||
Reworks the drag&drop to use `transform` to swap the positions of items in a sortable list. This allows for items to be animated as they're being sorted.
crisbeto
force-pushed
the
drag-drop-sorting-animation
branch
from
034edbb to
884ecf7
Compare
|
I've addressed the feedback @jelbourn. |
josephperrott
pushed a commit
that referenced
this pull request
Aug 7, 2018
josephperrott
pushed a commit
that referenced
this pull request
Aug 7, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks the drag&drop to use
transformto swap the positions of items in a sortable list. This allows for items to be animated as they're being sorted.Live demo: https://material-cb7ec.firebaseapp.com/drag-drop