Skip to content

fix(form-field): search inputs not being reset on safari #12413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2018

Conversation

crisbeto
Copy link
Member

Fixes Safari's custom styling for input[type='search'] not being reset inside of form fields.

Fixes #12408.

Fixes Safari's custom styling for `input[type='search']` not being reset inside of form fields.

Fixes angular#12408.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jul 27, 2018
@crisbeto crisbeto requested a review from mmalerba as a code owner July 27, 2018 20:10
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 27, 2018
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 27, 2018
@ngbot
Copy link

ngbot bot commented Jul 27, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "continuous-integration/travis-ci/pr" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@crisbeto crisbeto changed the title fix(form-field): reset inputs not being reset on safari fix(form-field): search inputs not being reset on safari Jul 28, 2018
@jelbourn jelbourn merged commit 4884dac into angular:master Aug 1, 2018
jelbourn pushed a commit that referenced this pull request Aug 7, 2018
Fixes Safari's custom styling for `input[type='search']` not being reset inside of form fields.

Fixes #12408.
jelbourn pushed a commit that referenced this pull request Aug 7, 2018
Fixes Safari's custom styling for `input[type='search']` not being reset inside of form fields.

Fixes #12408.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Safari matInput rendering bug for type="search"
4 participants