Skip to content

docs: properly show method overloads #12308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2018
Merged

docs: properly show method overloads #12308

merged 1 commit into from
Jul 24, 2018

Conversation

devversion
Copy link
Member

@devversion devversion commented Jul 21, 2018 •
edited
Loading

Shows method overloads in the documentation instead of showing the overload-base method that has most likely no JSDoc nor good-explaining parameter names

@devversion
docs: properly show method overloads
b842baa 
* Shows method overloads in the documentation instead of showing the overload-base method that has most likely no `JSDoc` nor good-explaining parameter names (parameters have multiple purposes and types)
@devversion devversion added docs This issue is related to documentation pr: merge safe target: patch This PR is targeted for the next patch release labels Jul 21, 2018
@devversion devversion requested a review from jelbourn as a code owner July 21, 2018 14:13
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 21, 2018
jelbourn
jelbourn approved these changes Jul 24, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 24, 2018
@mmalerba mmalerba merged commit 634163e into angular:master Jul 24, 2018
mmalerba pushed a commit that referenced this pull request Jul 30, 2018
@devversion @mmalerba
docs: properly show method overloads (#12308)
25d0bf4 
* Shows method overloads in the documentation instead of showing the overload-base method that has most likely no `JSDoc` nor good-explaining parameter names (parameters have multiple purposes and types)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devversion @jelbourn @googlebot @mmalerba