Skip to content

docs(ripple): fix missing jsdoc descriptions #12305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2018
Merged

docs(ripple): fix missing jsdoc descriptions #12305

merged 1 commit into from
Jul 23, 2018

Conversation

devversion
Copy link
Member

  • Fixes missing JSDoc descriptions for the ripple API that will be shown in the docs
  • Hides the public methods that are implemented as part of the RippleTarget.

@devversion
docs(ripple): fix missing jsdoc descriptions
f892f71 
* Fixes missing JSDoc descriptions for the ripple API that will be shown in the docs
* Hides the public methods that are implemented as part of the `RippleTarget`.
@devversion devversion added docs This issue is related to documentation target: patch This PR is targeted for the next patch release labels Jul 21, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 21, 2018
crisbeto
crisbeto approved these changes Jul 21, 2018
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 21, 2018
@ngbot
Copy link

ngbot bot commented Jul 21, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "continuous-integration/travis-ci/pr" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@josephperrott josephperrott merged commit 82915c7 into angular:master Jul 23, 2018
@devversion devversion deleted the docs/ripple-missing-jsdoc branch July 23, 2018 14:14
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@devversion @crisbeto @jelbourn @googlebot @josephperrott