chore: cleanup schematics #12266
Merged
chore: cleanup schematics #12266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
devversion
commented
Jul 18, 2018
devversion
commented
- Add licenses to all source files for the schematics & update-tool
- Enables linting for schematics folder (except template files; and utils taken verbatim from devkit)
- Fixes wrong file extension for tests inside of schematics
- Fixes IDE warnings in schematics folder (related: https://youtrack.jetbrains.com/issue/WEB-33060)
googlebot
added
the
cla: yes
mmalerba
reviewed
Jul 18, 2018
| * Use of this source code is governed by an MIT-style license that can be | ||
| * found in the LICENSE file at https://angular.io/license | ||
| */ | ||
| /* tslint:disable */ |
There was a problem hiding this comment.
why are we removing the license on these files if we added it everywhere else?
There was a problem hiding this comment.
Good catch. I accidentally removed them. Re-added and also uses Google LLC instead of Google Inc.
mmalerba
approved these changes
Jul 18, 2018
mmalerba
added
pr: lgtm
action: merge
|
@devversion looks like there is a lint error |
josephperrott
removed
the
action: merge
* Add licenses to all source files for the schematics & update-tool * Enables linting for schematics folder (except template files; and utils taken verbatim from devkit) * Fixes wrong file extension for tests inside of schematics * Fixes IDE warnings in schematics folder (related: https://youtrack.jetbrains.com/issue/WEB-33060)
devversion
force-pushed
the
chore/cleanup-schematics
branch
from
93f1f8e to
12cf39d
Compare
|
@josephperrott Fixed (happened because of the new tree schematic that has been merged) |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.