Skip to content

chore: remove screenshot testing #12155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2018

Conversation

devversion
Copy link
Member

  • Removes the screenshot test tool since Angular Material is visually being tested inside of Google.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 11, 2018
* Removes the screenshot test tool since Angular Material is visually being tested inside of Google.
@devversion devversion force-pushed the chore/screenshot-testing-remove branch from 4d0aa56 to efd6c2b Compare July 11, 2018 14:26
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit afb0ee3 into angular:master Jul 11, 2018
@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 11, 2018
@andreroggeri
Copy link
Contributor

@jelbourn @tinayuangao @devversion Is there anything public related to the visual testing for Google products ? I'm very interested on visual regression tools, specially if its made for Angular ! 😀

@jelbourn
Copy link
Member

It's all internal to Google presently.

victoriaaa234 pushed a commit that referenced this pull request Jul 25, 2018
Removes the screenshot test tool since Angular Material is visually being tested inside of Google.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants