Skip to content

fix(tabs): ripple overflow in internet explorer #12036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2018

Conversation

devversion
Copy link
Member

  • Fixes that ripples and the ink bar exceed the visible tab-bar boundaries. This seems to be caused by a new layer that exceeds the parent element boundaries and overflow: hidden style.

Fixes #10276.

cc. @crisbeto. Maybe you have some other ideas (you mostly do IE11 workarounds)

* Fixes that ripples and the ink bar exceed the visible tab-bar boundaries. This seems to be caused by a new layer that exceeds the parent element boundaries and `overflow: hidden` style.

Fixes angular#10276
@devversion devversion added the target: patch This PR is targeted for the next patch release label Jul 3, 2018
@devversion devversion requested a review from andrewseguin as a code owner July 3, 2018 13:12
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 3, 2018
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think I tried poking at this issue a while ago, but I wasn't able to find a solution.

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 3, 2018
@josephperrott josephperrott merged commit f35a314 into angular:master Jul 18, 2018
@devversion devversion deleted the fix/tabs-overflow-ie-11 branch July 18, 2018 22:14
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tabs] [IE] Ripple animation overflow over pagination
5 participants