Skip to content

build: index file for cdk-experimental/scrolling not being generated #11958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jun 27, 2018

Fixes the index.js and public-api.js files for the cdk-experimental/scrolling packages not being generated. The issue seems to come from the fact that the files aren't referenced by any other files which causes them to not be output. This ended up breaking the demo app.

@crisbeto crisbeto requested a review from mmalerba as a code owner June 27, 2018 20:36
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 27, 2018
Fixes the `index.js` and `public-api.js` files for the `cdk-experimental/scrolling` packages not being generated. The issue seems to come from the fact that the files aren't reference by any other files which causes them to not be output.
@crisbeto crisbeto requested a review from jelbourn as a code owner June 27, 2018 20:59
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jun 27, 2018
@josephperrott josephperrott merged commit 794509d into angular:master Jun 27, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants