fix(autocomplete): form control being marked as touched too early when clicking on an option #11908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
josephperrott
added
pr: lgtm
action: merge
crisbeto
force-pushed
the
11903/autocomplete-mark-as-touched
branch
from
0c7b057 to
707905c
Compare
andrewseguin
added
the
P3
crisbeto
force-pushed
the
11903/autocomplete-mark-as-touched
branch
from
707905c to
078ece6
Compare
crisbeto
force-pushed
the
11903/autocomplete-mark-as-touched
branch
from
078ece6 to
98c9a4a
Compare
crisbeto
force-pushed
the
11903/autocomplete-mark-as-touched
branch
from
98c9a4a to
d0b8dd5
Compare
crisbeto
force-pushed
the
11903/autocomplete-mark-as-touched
branch
from
d0b8dd5 to
7cbe36c
Compare
…early when clicking on an option Currently we mark the autocomplete form control as touched on every blur event. This can be an issue for the case where a control is being validated on blur, because the input becomes blurred as soon as the user has their pointer down on something else (e.g. one of the options). This will cause validation to run before the value has been assigned. With these changes we switch to marking the control as touched once the panel has been closed. Fixes angular#11903.
crisbeto
force-pushed
the
11903/autocomplete-mark-as-touched
branch
from
7cbe36c to
8d0658d
Compare
|
Failing a number of google3 tests because tests were testing for errors on blur. Will probably have to individually change the tests to actually touch the form control. |
andrewseguin
added
needs rebase
and removed
cla: yes
andrewseguin
removed
the
P3
josephperrott
added
action: cleanup
josephperrott
requested review from
amysorto and
mmalerba
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we mark the autocomplete form control as touched on every blur event. This can be an issue for the case where a control is being validated on blur, because the input becomes blurred as soon as the user has their pointer down on something else (e.g. one of the options). This will cause validation to run before the value has been assigned. With these changes we switch to marking the control as touched once the panel has been closed.
Fixes #11903.