feat(overlay): expose keydown events on the opened overlay #11867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
Jun 22, 2018
| @@ -205,6 +205,9 @@ export class CdkConnectedOverlay implements OnDestroy, OnChanges { | |||
| /** Event emitted when the overlay has been detached. */ | |||
| @Output() detach = new EventEmitter<void>(); | |||
|
|
|||
| /** Emits when there are keyboard events that are targeted at the overlay. */ | |||
| @Output() keydownEvents = new EventEmitter<KeyboardEvent>(); | |||
There was a problem hiding this comment.
Even though it's very unlikely for someone to bind a keydown to the overlay host, I wanted to avoid clashing with the native keydown.
There was a problem hiding this comment.
How about something like overlayKeydown, then? The "Events" suffix doesn't match any of the other events in the library
josephperrott
added
the
target: minor
Since the consumer doesn't have direct access to the overlay that is being opened, there's no way for them to listen for keyboard events. These changes expose the `OverlayRef.keydownEvents` via an output.
crisbeto
force-pushed
the
overlay-directives-keydown-event
branch
from
b9c6ed0 to
b061da0
Compare
|
Reworked based on the feedback. |
jelbourn
added
pr: lgtm
action: merge
victoriaaa234
pushed a commit
that referenced
this pull request
Jul 25, 2018
Since the consumer doesn't have direct access to the overlay that is being opened, there's no way for them to listen for keyboard events. These changes expose the `OverlayRef.keydownEvents` via an output.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the consumer doesn't have direct access to the overlay that is being opened, there's no way for them to listen for keyboard events. These changes expose the
OverlayRef.keydownEventsvia an output.