refactor(material/dialog): use type overload for open method #11731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
|
Turns out this is a major change because people wrap |
crisbeto
added
target: patch
crisbeto
force-pushed
the
dialog-open-overloads
branch
from
c98efaf to
0ea193c
Compare
crisbeto
force-pushed
the
dialog-open-overloads
branch
from
0ea193c to
0dab2b5
Compare
|
Here's the correspondig TypeScript issue: microsoft/TypeScript#14107 |
crisbeto
force-pushed
the
dialog-open-overloads
branch
from
0dab2b5 to
1505567
Compare
crisbeto
added
the
P3
crisbeto
force-pushed
the
dialog-open-overloads
branch
from
1505567 to
05c29df
Compare
crisbeto
force-pushed
the
dialog-open-overloads
branch
from
05c29df to
c0e6270
Compare
crisbeto
changed the title
* Reworks the `MatDialog.open` method to use overloads, rather than the single signature that has `componentOrTemplateRef: ComponentType<T> | TemplateRef<T>`. This makes the separation clearer and looks nicer in autocompletion. * Adds docs for the `MatBottomSheet.open` method.
crisbeto
force-pushed
the
dialog-open-overloads
branch
from
c0e6270 to
3342fd9
Compare
annieyw
pushed a commit
that referenced
this pull request
Oct 14, 2020
* Reworks the `MatDialog.open` method to use overloads, rather than the single signature that has `componentOrTemplateRef: ComponentType<T> | TemplateRef<T>`. This makes the separation clearer and looks nicer in autocompletion. * Adds docs for the `MatBottomSheet.open` method. (cherry picked from commit 70e9eb9)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MatDialog.openmethod to use overloads, rather than the single signature that hascomponentOrTemplateRef: ComponentType<T> | TemplateRef<T>. This makes the separation clearer and looks nicer in autocompletion.MatBottomSheet.openmethod.