-
Notifications
You must be signed in to change notification settings - Fork 6.8k
feat(slide-toggle): make slide-toggle click and drag actions configurable #11719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,4 +8,4 @@ | |
|
||
export * from './slide-toggle-module'; | ||
export * from './slide-toggle'; | ||
|
||
export * from './slide-toggle-config'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
/** | ||
* @license | ||
* Copyright Google LLC All Rights Reserved. | ||
* | ||
* Use of this source code is governed by an MIT-style license that can be | ||
* found in the LICENSE file at https://angular.io/license | ||
*/ | ||
import {InjectionToken} from '@angular/core'; | ||
|
||
|
||
/** Default `mat-slide-toggle` options that can be overridden. */ | ||
export interface MatSlideToggleDefaultOptions { | ||
/** Whether toggle action triggers value changes in slide toggle. */ | ||
disableToggleValue?: boolean; | ||
/** Whether drag action triggers value changes in slide toggle. */ | ||
disableDragValue?: boolean; | ||
} | ||
|
||
/** Injection token to be used to override the default options for `mat-slide-toggle`. */ | ||
export const MAT_SLIDE_TOGGLE_DEFAULT_OPTIONS = | ||
new InjectionToken<MatSlideToggleDefaultOptions>('mat-slide-toggle-default-options', { | ||
providedIn: 'root', | ||
factory: () => ({disableToggleValue: false, disableDragValue: false}) | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you just move
this.toggleChange.emit()
down below thethis._emitChangeEvent()
? That's basically the same and removes the unnecessary check.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This
this.toggleChange.emit()
also fires whenthis.defaults.disableToggleValue
is true. When the value is true, the native element's checked status is reverted, and no value change is emitted.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense.