fix(form-field): label gap not being calculated when switching to outline dynamically #11658
Conversation
googlebot
added
the
cla: yes
| @@ -148,6 +148,11 @@ export class MatFormField extends _MatFormFieldMixinBase | |||
| return this._appearance || this._defaultOptions && this._defaultOptions.appearance || 'legacy'; | |||
| } | |||
| set appearance(value: MatFormFieldAppearance) { | |||
| // If we're switching to `outline` from another appearance, we have to recalculate the gap. | |||
| if (value !== this._appearance && value === 'outline') { | |||
There was a problem hiding this comment.
should we add a test for this?
There was a problem hiding this comment.
I wasn't able to get it to measure the element within a unit test. IIRC I wasn't able to get that Promise.resolve to flush correctly.
There was a problem hiding this comment.
did you try just doing a real async test?
There was a problem hiding this comment.
I got some time to take a better look and it turns out that my test wasn't working because it didn't have a label. I've pushed a test that fails when we expect it to.
…line dynamically Fixes the form field gap not being calculated if the field switches to the `outline` appearance after init. Fixes angular#11653.
crisbeto
force-pushed
the
11653/form-field-apperance-change
branch
from
fbf28d9 to
dc8ea5a
Compare
mmalerba
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes the form field gap not being calculated if the field switches to the
outlineappearance after init.Fixes #11653.