fix(slide-toggle): disable animations when using NoopAnimationsModule #11414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tinayuangao
reviewed
May 21, 2018
| @@ -107,7 +107,7 @@ $mat-slide-toggle-bar-track-width: $mat-slide-toggle-bar-width - $mat-slide-togg | |||
|
|
|||
| // Once the thumb container is being dragged around, we remove the transition duration to | |||
| // make the drag feeling fast and not delayed. | |||
| &.mat-dragging, &:active { | |||
| &.mat-dragging, &:active, ._mat-animation-noopable & { | |||
There was a problem hiding this comment.
Why does -noopable & need this cursor-grabbing?
There was a problem hiding this comment.
ops, good catch. It's fixed now.
Fixes the slide toggle transitions not being disabled when using the `NoopAnimationsModule`. Relates to angular#10590.
crisbeto
force-pushed
the
slide-toggle-noop-animations
branch
from
89e1e21 to
e6c43e6
Compare
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the slide toggle transitions not being disabled when using the
NoopAnimationsModule.Relates to #10590.