build: fix rollup global name in umd bundle #11413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Between rxjs 5.5 and 6.0 the global name changed from `Rx` to `rxjs`, however ours is still set to `Rx`. These changes switch to using the correct name. Fixes angular#11299.
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
CaerusKaru
added a commit
to angular/flex-layout
that referenced
this pull request
May 24, 2018
* Equivalent commit to angular/components#11413
mmalerba
pushed a commit
that referenced
this pull request
May 24, 2018
Between rxjs 5.5 and 6.0 the global name changed from `Rx` to `rxjs`, however ours is still set to `Rx`. These changes switch to using the correct name. Fixes #11299.
ThomasBurleson
pushed a commit
to angular/flex-layout
that referenced
this pull request
May 31, 2018
* Equivalent commit to angular/components#11413
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Between rxjs 5.5 and 6.0 the global name changed from
Rxtorxjs, however ours is still set toRx. These changes switch to using the correct name.Fixes #11299.