feat(overlay): allow for Directionality instance to be passed in #11411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
requested review from
andrewseguin,
jelbourn and
mmalerba
as code owners
googlebot
added
the
cla: yes
jelbourn
reviewed
May 22, 2018
src/cdk/overlay/overlay-ref.ts
Outdated
| /** | ||
| * Layout direction of the overlay panel. | ||
| */ | ||
| get direction(): Direction { |
There was a problem hiding this comment.
Could we make this a function getDirection() since setDirection is already there? I think that's more clear than having a separate readonly property
crisbeto
force-pushed
the
overlay-directionality
branch
from
50cb111 to
e427327
Compare
jelbourn
added
pr: lgtm
action: merge
|
Hi @crisbeto! This PR has merge conflicts due to recent upstream merges. |
Allows for a `Directionality` instance to be passed in to the `OverlayRef`, in addition to a static `Direction`. Using a `Directionality` has the advantage of not having to keep the overlay's direction in sync manually with whatever component triggered it. It also gets rid of some annoying null checks.
crisbeto
force-pushed
the
overlay-directionality
branch
from
e427327 to
129989e
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for a
Directionalityinstance to be passed in to theOverlayRef, in addition to a staticDirection. Using aDirectionalityhas the advantage of not having to keep the overlay's direction in sync manually with whatever component triggered it. It also gets rid of some annoying null checks.