feat(a11y): add cdkAriaLive directive #11352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
May 15, 2018
| providers: [{ | ||
| provide: MutationObserverFactory, | ||
| useValue: { | ||
| create: function(callback: Function) { |
| selector: '[cdkAriaLive]' | ||
| }) | ||
| export class CdkAriaLive implements OnDestroy { | ||
| @Input('cdkAriaLive') |
| this._subscription = null; | ||
| } | ||
| } else { | ||
| this._subscription = this._ngZone.runOutsideAngular( |
There was a problem hiding this comment.
Shouldn't you only set up a new subscription if there isn't already one?
|
Looks like circle still has a failure |
jelbourn
added
pr: lgtm
action: merge
josephperrott
added
target: patch
mmalerba
added
blocked
|
@devversion thinks this directive may not be necessary. I'll experiment with getting the datepicker a11y working without it and then decide what to do with this PR |
|
@devversion I found that just setting |
mmalerba
added
action: merge
|
@mmalerba Sounds good. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unblocks #11144