Skip to content

refactor(overlay): allow HTMLElement to be passed in directly to connected position #11322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2018
Merged

refactor(overlay): allow HTMLElement to be passed in directly to connected position #11322

merged 1 commit into from
May 15, 2018

Conversation

crisbeto
Copy link
Member

Allows for an HTMLElement to be passed in directly to the FlexibleConnectedPositionStrategy, in addition to one wrapped in an ElementRef.

Fixes #11320.

@crisbeto crisbeto requested a review from jelbourn as a code owner May 14, 2018 14:50
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 14, 2018
amcdnl
amcdnl approved these changes May 14, 2018
View reviewed changes
Copy link
Contributor

@amcdnl amcdnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jelbourn
jelbourn approved these changes May 14, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed pr: needs review labels May 14, 2018
@ngbot
Copy link

ngbot bot commented May 14, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: build" is failing
    failure status "branch manager" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@crisbeto
refactor(overlay): allow HTMLElement to be passed in directly to conn…
177c357 
…ected position

Allows for an `HTMLElement` to be passed in directly to the `FlexibleConnectedPositionStrategy`, in addition to one wrapped in an `ElementRef`.

Fixes angular#11320.
@crisbeto crisbeto force-pushed the 11320/connected-position-element-ref branch from e07b233 to 177c357 Compare May 14, 2018 19:23
@tinayuangao tinayuangao merged commit 04b076d into angular:master May 15, 2018
tinayuangao pushed a commit that referenced this pull request May 15, 2018
@crisbeto @tinayuangao
refactor(overlay): allow HTMLElement to be passed in directly to conn…
3ae4494 
…ected position (#11322)

Allows for an `HTMLElement` to be passed in directly to the `FlexibleConnectedPositionStrategy`, in addition to one wrapped in an `ElementRef`.

Fixes #11320.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amcdnl amcdnl amcdnl approved these changes

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CDK Overlay Flexible Reference API
5 participants
@crisbeto @amcdnl @jelbourn @googlebot @tinayuangao