Skip to content

docs(toolbar): set proper role value #11317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2018
Merged

docs(toolbar): set proper role value #11317

merged 1 commit into from
May 15, 2018

Conversation

alan-agius4
Copy link
Contributor

Based on https://www.w3.org/TR/wai-aria/#role_definitions there is no such role as header, but rather it should heading

Based on https://www.w3.org/TR/wai-aria/#role_definitions there is no such role as `header`, but rather it should `heading`
@alan-agius4 alan-agius4 requested a review from devversion as a code owner May 14, 2018 12:17
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 14, 2018
@devversion devversion added pr: lgtm Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker labels May 14, 2018
@ngbot
Copy link

ngbot bot commented May 14, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure missing required label: "target: *"
    pending status "ci/circleci: build" is pending
    pending status "continuous-integration/travis-ci/pr" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@tinayuangao tinayuangao merged commit bd9ba9c into angular:master May 15, 2018
@alan-agius4 alan-agius4 deleted the patch-1 branch May 15, 2018 04:24
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants