Skip to content

docs(chips): fix autocomplete-chips example #11298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2018
Merged

docs(chips): fix autocomplete-chips example #11298

merged 1 commit into from
May 15, 2018

Conversation

julianobrasil
Copy link
Contributor

Fixes #11291.

Although #11233 fixes the issue that prevented the chips removal, #11291 points to another issue: when the user pressed enter (or selected a chip from the autocomplete panel) to create the new chip, the autocomplete associated input wasn't cleared appropriately: it kept the last typed/selected item.

Current Behavior:

image

After fixing it

image

Fix suggested by @CurtisDS.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 12, 2018
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker labels May 13, 2018
@ngbot
Copy link

ngbot bot commented May 13, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "branch manager" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@tinayuangao tinayuangao merged commit cc2bf64 into angular:master May 15, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autocomplete list doesnt reset in MatChipList after adding a Chip in example
4 participants