feat(autocomplete): add the ability to set a different panel connection element #11284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
approved these changes
May 11, 2018
src/lib/autocomplete/autocomplete.md
Outdated
|
|
||
| <mat-autocomplete #auto="matAutocomplete"> | ||
| <mat-option *ngFor="let option of options" [value]="option"> | ||
| {{ option }} |
jelbourn
added
pr: lgtm
action: merge
…on element Currently the autocomplete panel gets attached to the trigger element, however this can be inflexible in the cases where people have a custom input wrapper. These changes add the ability to have an autocomplete be attached to an element that is different from the trigger. Fixes angular#11269.
crisbeto
force-pushed
the
11269/autocomplete-origin
branch
from
625ad6e to
144e0a5
Compare
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
May 15, 2018
…on element (angular#11284) Currently the autocomplete panel gets attached to the trigger element, however this can be inflexible in the cases where people have a custom input wrapper. These changes add the ability to have an autocomplete be attached to an element that is different from the trigger. Fixes angular#11269.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the autocomplete panel gets attached to the trigger element, however this can be inflexible in the cases where people have a custom input wrapper. These changes add the ability to have an autocomplete be attached to an element that is different from the trigger.
Fixes #11269.