Skip to content

docs(chips): use consistent data structure in autocomplete example #11175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2018
Merged

docs(chips): use consistent data structure in autocomplete example #11175

merged 1 commit into from
May 9, 2018

Conversation

kyoz
Copy link
Contributor

@kyoz kyoz commented May 5, 2018

No description provided.

@kyoz kyoz requested review from amcdnl and jelbourn as code owners May 5, 2018 07:49
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 5, 2018
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker labels May 5, 2018
@ngbot
Copy link

ngbot bot commented May 5, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure missing required label: "target: *"
    pending 2 pending code reviews

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

(remove)="remove(fruit)">
{{fruit.name}}
(removed)="remove(fruit)">
{{fruit}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you've accidentally added extra spaces here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha. yes it was mine. do i need to remove them ? 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for too late. i'v fixed it ^_^

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label May 9, 2018
@jelbourn jelbourn merged commit 714f065 into angular:master May 9, 2018
@kyoz kyoz deleted the banminkyoz branch May 10, 2018 02:39
josephperrott pushed a commit to josephperrott/components that referenced this pull request May 14, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants