-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(ng-add): install added packages #11163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, just one nit
src/lib/schematics/shell/index.ts
Outdated
@@ -1,4 +1,5 @@ | |||
import {chain, noop, Rule, Tree} from '@angular-devkit/schematics'; | |||
import {chain, noop, Rule, Tree, SchematicContext} from '@angular-devkit/schematics'; | |||
import { NodePackageInstallTask } from '@angular-devkit/schematics/tasks'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Remove spaces around import
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes #11159