Skip to content

fix(ng-add): install added packages #11163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2018
Merged

fix(ng-add): install added packages #11163

merged 1 commit into from
May 7, 2018

Conversation

clydin
Copy link
Member

@clydin clydin commented May 4, 2018

Fixes #11159

@clydin clydin requested a review from amcdnl as a code owner May 4, 2018 18:35
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 4, 2018
Copy link
Contributor

@amcdnl amcdnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just one nit

@@ -1,4 +1,5 @@
import {chain, noop, Rule, Tree} from '@angular-devkit/schematics';
import {chain, noop, Rule, Tree, SchematicContext} from '@angular-devkit/schematics';
import { NodePackageInstallTask } from '@angular-devkit/schematics/tasks';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Remove spaces around import

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@josephperrott josephperrott added the target: patch This PR is targeted for the next patch release label May 4, 2018
Copy link
Contributor

@amcdnl amcdnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amcdnl amcdnl added pr: lgtm action: merge The PR is ready for merge by the caretaker labels May 6, 2018
@josephperrott josephperrott merged commit be08eb9 into angular:master May 7, 2018
@clydin clydin deleted the add-package-install branch May 7, 2018 16:02
josephperrott pushed a commit to josephperrott/components that referenced this pull request May 8, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ng add @angular/material
4 participants