fix(tree) make change detection less often #11103
Conversation
googlebot
added
the
cla: yes
tinayuangao
added
action: merge
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
tinayuangao
added
the
target: patch
src/cdk/tree/tree.spec.ts
Outdated
| @@ -605,7 +605,9 @@ describe('CdkTree', () => { | |||
| try { | |||
| TestBed.createComponent(NestedCdkErrorTreeApp).detectChanges(); | |||
| flush(); | |||
| } catch { | |||
| } catch (e) { | |||
There was a problem hiding this comment.
@rafaelss95, e is removed
The CdkTree component calls change detection after each node insert, which has impact on performance. The fix is to call change detection only once, when a set of nodes is rendered. Related bug: angular#11101
stasmaxymov
force-pushed
the
improve-tree-performance
branch
from
f4b4cd9 to
0fbbe45
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
The CdkTree component calls change detection after each node insert, which has impact
on performance. The fix is to call change detection only once, when a set of nodes
is rendered.
Related bug: #11101