Skip to content

docs(snack-bar): expand a11y guidance #11012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2018
Merged

docs(snack-bar): expand a11y guidance #11012

merged 1 commit into from
Apr 26, 2018

Conversation

jelbourn
Copy link
Member

No description provided.

@jelbourn jelbourn added pr: needs review Accessibility This issue is related to accessibility (a11y) docs This issue is related to documentation labels Apr 25, 2018
@jelbourn jelbourn requested a review from josephperrott April 25, 2018 20:18
@jelbourn jelbourn requested a review from crisbeto as a code owner April 25, 2018 20:18
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 25, 2018
josephperrott
josephperrott approved these changes Apr 26, 2018
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed pr: needs review labels Apr 26, 2018
@ngbot
Copy link

ngbot bot commented Apr 26, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "continuous-integration/travis-ci/pr" is failing
    pending 1 pending code review

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@andrewseguin andrewseguin merged commit 31df21c into angular:master Apr 26, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

@crisbeto crisbeto Awaiting requested review from crisbeto

Assignees
No one assigned
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jelbourn @josephperrott @googlebot @andrewseguin