chore: disable cdk/coercion bazel tests #10823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelbourn
added
P1
googlebot
added
the
cla: yes
All bazel unit tests are broken due to rxjs 6.0. The coercion tests were not marked as manual for some reason.
josephperrott
approved these changes
Apr 12, 2018
| @@ -36,7 +36,6 @@ jobs: | |||
| # This may be unnecessary once rules_nodejs uses nodejs 8 | |||
| - run: bazel run @nodejs//:npm run postinstall | |||
| - run: bazel build src/... | |||
| - run: bazel test src/... | |||
There was a problem hiding this comment.
Comment out instead of removing?
There was a problem hiding this comment.
It will be a while before we can fix this and once we do fix it we won't just forget to turn it back on.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All bazel unit tests are broken due to rxjs 6.0. The coercion tests were
not marked as manual for some reason.