fix(overlay): handle OnDestroy in FullscreenOverlayContainer and use document injection token #10773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
|
@crisbeto Please rebase. Thanks |
|
Rebased. |
crisbeto
force-pushed
the
fullscreen-overlay-container-on-destroy
branch
from
820b5db to
77ed733
Compare
|
@crisbeto Got error saying Property '_document' is private and only accessible within class 'OverlayContainer'. |
tinayuangao
added
the
presubmit failures
crisbeto
force-pushed
the
fullscreen-overlay-container-on-destroy
branch
from
77ed733 to
497e867
Compare
|
Sorry @tinayuangao, I messed it up when rebasing. It's fixed now. |
crisbeto
removed
the
presubmit failures
…document injection token * Fixes the `fullscreenchange` event handler not being cleared from the `FullscreenOverlayContainer` once it's destroyed. * Uses the `DOCUMENT` token to avoid potential server-side rendering errors.
crisbeto
force-pushed
the
fullscreen-overlay-container-on-destroy
branch
from
497e867 to
d4550f6
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fullscreenchangeevent handler not being cleared from theFullscreenOverlayContaineronce it's destroyed.DOCUMENTtoken to avoid potential server-side rendering errors.