cleanup: migrate migration tool to schematics #10736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
Apr 6, 2018
src/lib/schematics/collection.json
Outdated
| @@ -9,6 +9,10 @@ | |||
| "schema": "./shell/schema.json", | |||
| "aliases": ["material-shell"] | |||
| }, | |||
| "ng-update": { | |||
| "description": "Attempts to make fixes to the application to make upgrading from Angular Material 5 to 6 easier", | |||
There was a problem hiding this comment.
How about
Updates API usage for the most recent major version of
Angular CDK and Angular Material
src/lib/schematics/update/update.ts
Outdated
| import {TslintFixTask} from '@angular-devkit/schematics/tasks'; | ||
| import * as path from 'path'; | ||
|
|
||
| export default function(): Rule { |
There was a problem hiding this comment.
Add a comment like Entry point for `ng update` from Angular CLI?
amcdnl
previously requested changes
Apr 9, 2018
| const moduleSpecifier = declaration.moduleSpecifier.getText(); | ||
| return moduleSpecifier.indexOf(materialModuleSpecifier) !== -1|| | ||
| moduleSpecifier.indexOf(cdkModuleSpecifier) !== -1; | ||
| } |
| data => data.replace === symbol.name || data.replace === identifier.text); | ||
|
|
||
| if (!classData) { | ||
| console.error(`Could not find updated name for identifier "${identifier.getText()}" in ` + |
There was a problem hiding this comment.
Should we console.error or throw error here?
There was a problem hiding this comment.
console.error, we still want to continue trying to detect and fix other issues
| } else { | ||
| return resolveBinSync('tslint', 'tslint'); | ||
| } | ||
| } |
mmalerba
changed the title
jelbourn
added
pr: lgtm
action: merge
|
@mmalerba Please rebase, thanks |
|
@tinayuangao done |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: everything in the
update/directory other thanupdate.tsis lifted out of https://github.com/angular/material-update-tool