Skip to content

fix(tree): fix nested node is not working #10635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2018
Merged

fix(tree): fix nested node is not working #10635

merged 1 commit into from
Mar 30, 2018

Conversation

tinayuangao
Copy link
Contributor

Fixes #10437

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 30, 2018
@tinayuangao tinayuangao requested a review from jelbourn March 30, 2018 17:30
jelbourn
jelbourn reviewed Mar 30, 2018
View reviewed changes
src/lib/tree/node.ts

ngOnDestroy() {
super.ngOnDestroy();
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a test that would have caught this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It only happen in aot or prod mode. We have test cover nested tree, but I'm not sure how can we run tests in aot mode.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... something seems odd about this. Neither of those modes should affect the class construction, and the child classes should always inherit its base class's methods. Do you have a reproduction w/ aot?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thanks for review

jelbourn
jelbourn approved these changes Mar 30, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as workaround until we figure out whats going on.

Can you add comments that explain why these methods are defined?

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful target: patch This PR is targeted for the next patch release and removed pr: needs review labels Mar 30, 2018
@tinayuangao tinayuangao mentioned this pull request Mar 30, 2018
Closed
@josephperrott josephperrott merged commit 7857b92 into angular:master Mar 30, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nested tree not load async nodes with AOT
4 participants
@tinayuangao @jelbourn @googlebot @josephperrott