feat(overlay): add the ability to set the default offsets on FlexibleConnectedPositionStrategy #10555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
Mar 26, 2018
| * Sets the default offset for the overlay's connection point on the x-axis. | ||
| * @param offset New offset in the X axis. | ||
| */ | ||
| withOffsetX(offset: number): this { |
There was a problem hiding this comment.
Can we call these withDefaultOffsetX, withDefaultOffsetY? That will make it more clear that the offsets aren't additive.
crisbeto
force-pushed
the
flexible-connected-position-offset
branch
from
a33cd33 to
946c117
Compare
jelbourn
added
pr: lgtm
action: merge
|
@crisbeto Looks like there are a couple errors, can you rebase and push again? |
…ConnectedPositionStrategy Ports over the functionality that we used to have on the `ConnectedPositionStrategy` where consumers can set a default offset on the position strategy itself, to which it'll fall back if a `ConnectedPosition` doesn't have an offset. This helps avoid repetition in the cases where the consumer wants to have the same offset on all positions.
crisbeto
force-pushed
the
flexible-connected-position-offset
branch
from
946c117 to
2a06373
Compare
|
Those seemed to be coming from master @josephperrott (e.g. the issue with the Browserstack key). I've rebased the PR. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports over the functionality that we used to have on the
ConnectedPositionStrategywhere consumers can set a default offset on the position strategy itself, to which it'll fall back if aConnectedPositiondoesn't have an offset. This helps avoid repetition in the cases where the consumer wants to have the same offset on all positions.