-
Notifications
You must be signed in to change notification settings - Fork 6.8k
docs(datepicker): add docs for custom calendar header #10543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -287,6 +287,20 @@ export class MyApp {} | |||
|
|||
<!-- example(datepicker-formats) --> | |||
|
|||
#### Customizing the calendar header | |||
|
|||
The header section of the calendar (the part containing the view switcher and previous and next |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe not the right time to ask this question, but why an API that takes a component as an input? We don't have any APIs like that elsewhere in the library, instead using templates and/or content projection.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Content projection wasn't feasible because it would have had to be passed through several layers <mat-datepicker>
--> <mat-datepicker-content>
--> <mat-calendar>
. A template may have been workable, but there's a fair chunk of logic that goes with the header so a component seemed cleaner. At some point I want to break the datepicker into a bunch of composable pieces, we may be able to change how this works at that point
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mmalerba can you rebase? |
Done |
the header example is not working on docs, i got this error in stackblitz: |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.