refactor(overlay): move connected position assertions into FlexibleConnectedPositionStrategy

[crisbeto]

Since the ConnectedPositionStrategy proxies everything to FlexibleConnectedPositionStrategy, these changes move the assertions that verify that the config looks correctly into the FlexibleConnectedPositionStrategy.

[jelbourn]

LGTM

[mmalerba]

@crisbeto there seems to be some failing tests

[crisbeto]

This is very odd. The errors definitely get thrown, but something ends up swallowing them.

[mmalerba]

Could it be related to the new error handling behavior in rxjs 6?

https://github.com/ReactiveX/rxjs/blob/master/CHANGELOG.md#600-alpha1-2018-01-12

error handling: Unhandled errors are no longer caught and rethrown, rather they are caught and scheduled to be thrown, which causes them to be reported to window.onerror or process.on('error'), depending on the environment. Consequently, teardown after a synchronous, unhandled, error will no longer occur, as the teardown would not exist, and producer interference cannot occur

[crisbeto]

Looks like that was the issue @mmalerba. I've pushed a fix.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}