Skip to content

docs(tree): fix dynamic tree demo #10384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2018
Merged

docs(tree): fix dynamic tree demo #10384

merged 1 commit into from
Mar 29, 2018

Conversation

tinayuangao
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 12, 2018
@tinayuangao tinayuangao added target: major This PR is targeted for the next major release cla: yes PR author has agreed to Google's Contributor License Agreement pr: needs review and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Mar 12, 2018
@tinayuangao tinayuangao requested a review from jelbourn March 21, 2018 21:55
@tinayuangao tinayuangao added the P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful label Mar 23, 2018
jelbourn
jelbourn approved these changes Mar 26, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Mar 26, 2018
@josephperrott josephperrott merged commit 8c3ba34 into angular:master Mar 29, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tinayuangao @jelbourn @googlebot @josephperrott