Skip to content

refactor(autocomplete): remove 6.0.0 deletion targets #10319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2018
Merged

refactor(autocomplete): remove 6.0.0 deletion targets #10319

merged 1 commit into from
Mar 9, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Mar 8, 2018

Removes the deletion targets for 6.0.0 in the material/autocomplete module.

BREAKING CHANGES:

  • The defaults parameter in the MatAutocomplete constructor is now required.

@crisbeto
refactor(autocomplete): remove 6.0.0 deletion targets
84c5551 
Removes the deletion targets for 6.0.0 in the `material/autocomplete` module.

BREAKING CHANGES:
* The `defaults` parameter in the `MatAutocomplete` constructor is now required.
@crisbeto crisbeto requested a review from kara as a code owner March 8, 2018 03:58
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 8, 2018
jelbourn
jelbourn approved these changes Mar 8, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jelbourn
jelbourn approved these changes Mar 8, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Mar 8, 2018
@crisbeto
Copy link
Member Author

crisbeto commented Mar 8, 2018

Caretaker note: we need to remove google usages of the old API. This might require a cleanup before syncing this PR.

@crisbeto crisbeto added merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release labels Mar 8, 2018
@jelbourn jelbourn merged commit 0af5bca into angular:master Mar 9, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@kara kara Awaiting requested review from kara

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @jelbourn @googlebot