Skip to content

fix(radio): radios aren't checkable when the value is falsy #10315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2018
Merged

fix(radio): radios aren't checkable when the value is falsy #10315

merged 1 commit into from
Apr 18, 2018

Conversation

tinayuangao
Copy link
Contributor

@tinayuangao tinayuangao commented Mar 7, 2018 •
edited
Loading

Fixes #10195

@tinayuangao tinayuangao requested a review from devversion as a code owner March 7, 2018 19:18
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 7, 2018
@tinayuangao tinayuangao added the target: patch This PR is targeted for the next patch release label Mar 7, 2018
@tinayuangao tinayuangao requested a review from jelbourn March 9, 2018 23:23
jelbourn
jelbourn approved these changes Mar 9, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Could you change the commit message to

fix(radio): radios aren't checkable when the value is falsy

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Mar 9, 2018
@tinayuangao tinayuangao changed the title fix(radio): Fix radio button group value did not change for false, 0,… fix(radio): radios aren't checkable when the value is falsy Mar 10, 2018
@mmalerba mmalerba merged commit 4e48cf4 into angular:master Apr 18, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion Awaiting requested review from devversion

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Radio button value does not work correctly with falsy values
4 participants
@tinayuangao @jelbourn @googlebot @mmalerba