Skip to content

Sidenav: mat-sidenav-content margins not updated when dir changed #9158

Closed
@langan

Description

@langan

Bug, feature request, or proposal:

Bug: mat-sidenav-content margins are not updated when text direction changes

What is the expected behavior?

When you switch to RTL or back to LTR the margins of mat-sidenav-content should be recalculates.

What is the current behavior?

When you change the text direction to RTL mat-sidenav-content keeps the LTR margins

What are the steps to reproduce?

https://stackblitz.com/edit/angular-ysmyrn

What is the use-case or motivation for changing an existing behavior?

Switching from LTR / RTL shouldn't require a reload of the page.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Angular: 5.0.0
Angular Material: 5.0.2

Is there anything else we should know?

Looking at this line https://github.com/angular/material2/blob/c3d7cd96de6f06e1530658e41d1e8aa3ba74805e/src/lib/sidenav/drawer.ts#L493 maybe we should also call _updateContentMargins ?

Metadata

Metadata

Assignees

Labels

P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions