Skip to content

Make all components OnPush #5035

Closed
Closed
@jelbourn

Description

@jelbourn
  • MdAutocomplete
  • MdAnchor
  • MdButtonToggle
  • MdOptgroup
  • MdOption
  • MdPseudoCheckbox
  • MdDatepicker
  • MdDialogContainer
  • MdExpansionPanelHeader
  • MdExpansionPanel
  • MdGridList
  • MdGridTile
  • MdGridTileText
  • MdInputContainer
  • MdList
  • MdListItem
  • MdMenu
  • MdMenuItem
  • MdSpinner
  • MdSelect
  • MdSlider
  • SimpleSnackBar
  • MdSnackBarContainer
  • MdTabBody
  • MdTabGroup
  • MdTabHeader
  • MdTab
  • MdTabNavBar
  • TooltipComponent
  • MdSidenavContainer

We should make these change incrementally, tackling one high-level component at a time (e.g., "tabs"). This will make it easier to revert in case something goes wrong after the change (and also help prevent a rebasing nightmare).

Couple of things worth noting:

  • Most components should be as simple as adding OnPush to the config. This is the case if the component just has simple inputs and outputs.
  • Anything that implements ControlValueAccessor needs markForCheck in the forms hooks

Metadata

Metadata

Assignees

Labels

P2The issue is important to a large percentage of users, with a workaround

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions