Skip to content

bug(typography): deprecated typography config doesn't pass input level to underlying config function #23216

Open
@lagatchell

Description

@lagatchell

Reproduction

Steps to reproduce:

  1. Define a typography config in styles.scss and add a typography level for $input
$custom-typography: mat-typography-config(
  $input: mat-typography-level(14px, 1.25, 400)
);
  1. Add @debug to print the resulting configuration
@debug $custom-typography;
  1. npm start
  2. Notice that the typography level for input is still the default
    image

Expected Behavior

The mat-topography-config function should correctly apply a mat-typography-level for $input.

Actual Behavior

$input argument is ignored, because it is never passed to the underlying define-typography-config function.
https://github.com/angular/components/blob/12.0.x/src/material/core/typography/_typography-deprecated.scss#L36

I would be willing to contribute a fix for this issue.

Environment

  • Angular: 12.x
  • CDK/Material: 12.x
  • Browser(s): All
  • Operating System (e.g. Windows, macOS, Ubuntu): Windows

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgentarea: theming

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions