Mat-Dialog: Possible memory leak when dialog includes textarea, input, etc.

[tp1906]

Reproduction

Use StackBlitz to reproduce your issue: https://stackblitz.com/edit/components-issue-yp5k44?file=src/app/dialog-overview-example-dialog.html

Steps to reproduce:

1. Run application, click on open dialog button
2. Enter text and close dialog, repeat this step.
3. Go to Chrome Memory tab and run head snapshot. View MyDialogComponent and there are more than one instance created.
4. Refresh chrome tab
5. Open dialog and close without entering into text area
6. Go to Chrome Memory tab and run head snapshot. View MyDialogComponent and there is only one instance created.

Expected Behavior

What behavior were you expecting to see?

I could be reading the chrome head snapshot incorrectly but I would expect there to be 1 instance of the Dialog component (MyDialogComponent) regardless if I enter something into the text-area or not.

Actual Behavior

What behavior did you actually see?

The number of instances grows by 2 each time the dialog is opened and text is entered into the text-area.

Environment

• Angular: 10.1.0
• CDK/Material: 10.2.1
• Browser(s): Chrome
• Operating System (e.g. Windows, macOS, Ubuntu): Windows

[jelbourn]

@tp1906 I tried this and found that, no matter what I did (entering text into the text areas or not), I couldn't reproduce this; there was only ever one instance of the dialog in the heap snapshot.

Do you have any other information for reproduction?

[tp1906]

Can you send me a screenshot of your heap snapshot? I always see +2 or +3 after the mat-dialog. Do you think this could be an issue with chrome?

…

Sent from my iPhone

On Sep 17, 2020, at 5:45 PM, Jeremy Elbourn ***@***.***> wrote:  @tp1906 I tried this and found that, no matter what I did (entering text into the text areas or not), I couldn't reproduce this; there was only ever one instance of the dialog in the heap snapshot. Do you have any other information for reproduction? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[tp1906]

My apologies...I gave you the incorrect stackblitz in the original ticket. Here is the correct one: https://stackblitz.com/edit/angular-8fup8q?. Though I want to point out that what I see in the heap snapshot while running in stackblitz is different when I run this via http://localhost:4200 which is compiled using vsCode. Do you know why I see different heap snapshots when using these two methods?

What I see when running http://localhost:4200:

What I see when running via stackblitz: