Skip to content

dialog: example prompts should follow Material Design guidance #16746

Closed
@bisonfoutu

Description

@bisonfoutu

I just noticed while looking at the overview of the Dialog component that the code sample illustrating dialog structure directives did not follow the Material Design guidelines regarding dialogs and alert dialogs.

For dialogs, avoid ambiguous questions as "Are you sure ?" (even though I'm aware that the dialog's title is "Delete all", but then we could just ask "Delete all elements ?" as a title).
Since the provided dialog surely resembles an alert dialog, the example should also provide some explicit action labels, like "Cancel" and "Delete" instead of "No" and "Yes".

I believe the examples provided in Angular Material's documentation should reflect Material Design guidelines.
I usually expect documentation examples to follow best practices, especially regarding a library as serious as Angular Material.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgentdocsThis issue is related to documentationmaterial specIssue related to the Material Design spec https://material.io/design/

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions