Skip to content

Material Schematics missing external dependency #11341

Closed
@cgatian

Description

@cgatian

Bug, feature request, or proposal:

parse5 is used within schematics/utils/html.ts but is never listed as a dependency in package.json. This prevents being able to extending the material schematics without library developers adding this dependency.

What is the expected behavior?

parse5 should be listed as a dependency of material schematics.

What is the current behavior?

import/require statement fails when material schematic collection is used with externalSchematic

externalSchematic('@angular/material', 'material-shell', {}),  // Errors

What are the steps to reproduce?

Clone this repository and follow README

What is the use-case or motivation for changing an existing behavior?

Developers wishing to extend the existing Material schematics need to include parse5 as a dependency.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

6.0+

Metadata

Metadata

Assignees

Labels

needs: discussionFurther discussion with the team is needed before proceeding

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions