Skip to content

Commit e48778d

Browse files
committed
fix(cdk/dialog): provide proper shaped Directionality
#30702 added a `valueSignal` property to `Directionality`, this PR adds it to the directionality provided by cdk-dialog as well.
1 parent 48894ad commit e48778d

File tree

1 file changed

+19
-11
lines changed

1 file changed

+19
-11
lines changed

src/cdk/dialog/dialog.ts

Lines changed: 19 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -7,26 +7,27 @@
77
*/
88

99
import {
10-
TemplateRef,
10+
ComponentRef,
1111
Injectable,
1212
Injector,
1313
OnDestroy,
14-
Type,
1514
StaticProvider,
16-
ComponentRef,
15+
TemplateRef,
16+
Type,
1717
inject,
18+
signal,
1819
} from '@angular/core';
20+
import {Observable, Subject, defer, of as observableOf} from 'rxjs';
21+
import {startWith} from 'rxjs/operators';
22+
import {_IdGenerator} from '../a11y';
23+
import {Directionality} from '../bidi';
24+
import {ComponentType, Overlay, OverlayConfig, OverlayContainer, OverlayRef} from '../overlay';
1925
import {BasePortalOutlet, ComponentPortal, TemplatePortal} from '../portal';
20-
import {of as observableOf, Observable, Subject, defer} from 'rxjs';
21-
import {DialogRef} from './dialog-ref';
2226
import {DialogConfig} from './dialog-config';
23-
import {Directionality} from '../bidi';
24-
import {_IdGenerator} from '../a11y';
25-
import {ComponentType, Overlay, OverlayRef, OverlayConfig, OverlayContainer} from '../overlay';
26-
import {startWith} from 'rxjs/operators';
27+
import {DialogRef} from './dialog-ref';
2728

28-
import {DEFAULT_DIALOG_CONFIG, DIALOG_DATA, DIALOG_SCROLL_STRATEGY} from './dialog-injectors';
2929
import {CdkDialogContainer} from './dialog-container';
30+
import {DEFAULT_DIALOG_CONFIG, DIALOG_DATA, DIALOG_SCROLL_STRATEGY} from './dialog-injectors';
3031

3132
@Injectable({providedIn: 'root'})
3233
export class Dialog implements OnDestroy {
@@ -315,9 +316,16 @@ export class Dialog implements OnDestroy {
315316
(!userInjector ||
316317
!userInjector.get<Directionality | null>(Directionality, null, {optional: true}))
317318
) {
319+
const valueSignal = signal(config.direction);
318320
providers.push({
319321
provide: Directionality,
320-
useValue: {value: config.direction, change: observableOf()},
322+
useValue: {
323+
valueSignal,
324+
get value() {
325+
return valueSignal();
326+
},
327+
change: observableOf(),
328+
},
321329
});
322330
}
323331

0 commit comments

Comments
 (0)