Skip to content

Commit 03fb711

Browse files
devversionjelbourn
authored andcommitted
build: dgeni bazel target misses runtime fine-grained dep (#15649)
Due to the fact that various targets only depend on their TypeScript source Bazel target, the logic that is reponsible for determining the Bazel managed dependency path is not working because the `nodejs_binary` rule is not able to determine the `NodeModuleInfo` Bazel provider from the TypeScript compilation provider output. See: https://github.com/bazelbuild/rules_nodejs/blob/fe1d1c03630f999c57a63dc3fe1f6ad52ff61c6a/internal/node/node.bzl#L60 Therefore we need to make sure that we don't transitively depend on fine-grained dependencies (such as `@npm//highlight.js`) which *seem* to be transitively brought in by the TypeScript target. This is not correct and prone to unexpected failures (as we experienced on `master)
1 parent 98e5ea4 commit 03fb711

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

tools/dgeni/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ ts_library(
2020
"@npm//@types/node",
2121
"@npm//dgeni",
2222
"@npm//dgeni-packages",
23+
"@npm//highlight.js",
2324
"//tools/highlight-files:sources",
2425
],
2526
tsconfig = ":tsconfig.json",

0 commit comments

Comments
 (0)