Skip to content

refactor(@angular/platform-browser-dynamic): relocate DOMTestComponentRenderer to @angular/platform-browser #60453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

alan-agius4
Copy link
Contributor

This commit moves DOMTestComponentRenderer to @angular/platform-browser/testing, allowing the Angular CLI to eliminate its dependency on @angular/platform-browser-dynamic, which would no longer be required for new projects.

@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Mar 19, 2025
…r` to `@angular/platform-browser`

This commit moves `DOMTestComponentRenderer` to `@angular/platform-browser/testing`, allowing the Angular CLI to eliminate its dependency on `@angular/platform-browser-dynamic`, which would no longer be required for new projects.
@alan-agius4 alan-agius4 force-pushed the platform-browser-dynamic branch from 1e566ff to b8853bd Compare March 19, 2025 10:45
@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Mar 19, 2025
@ngbot ngbot bot added this to the Backlog milestone Mar 19, 2025
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Mar 19, 2025
@alan-agius4 alan-agius4 removed the request for review from AndrewKushnir March 19, 2025 11:30
@pullapprove pullapprove bot requested a review from AndrewKushnir March 19, 2025 11:30
@alan-agius4 alan-agius4 removed the request for review from pkozlowski-opensource March 19, 2025 11:30
@pullapprove pullapprove bot requested a review from atscott March 19, 2025 11:30
@pullapprove pullapprove bot requested a review from AndrewKushnir March 19, 2025 16:07
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@pullapprove pullapprove bot requested a review from devversion March 19, 2025 16:09
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: public-api

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 19, 2025
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this pull request Mar 19, 2025
This commit remove the dependency on `@angular/platform-browser-dynamic` from new projects.

This is now possible due to angular/angular#60453
@pkozlowski-opensource
Copy link
Member

This PR was merged into the repository by commit 5753aa7.

The changes were merged into the following branches: main, 19.2.x

pkozlowski-opensource pushed a commit that referenced this pull request Mar 19, 2025
…r` to `@angular/platform-browser` (#60453)

This commit moves `DOMTestComponentRenderer` to `@angular/platform-browser/testing`, allowing the Angular CLI to eliminate its dependency on `@angular/platform-browser-dynamic`, which would no longer be required for new projects.

PR Close #60453
@alan-agius4 alan-agius4 deleted the platform-browser-dynamic branch March 19, 2025 18:09
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this pull request Mar 20, 2025
This commit remove the dependency on `@angular/platform-browser-dynamic` from new projects.

This is now possible due to angular/angular#60453
alan-agius4 added a commit to angular/angular-cli that referenced this pull request Mar 20, 2025
This commit remove the dependency on `@angular/platform-browser-dynamic` from new projects.

This is now possible due to angular/angular#60453
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants