refactor(core): manual tick when one is scheduled switches to micro…
#56930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…task scheduler This commit updates the logic that switches the zoneless scheduler to a microtask scheduler from applying only when the scheduler runs to also when a change detection was scheduled but gets pre-empted by another call to `tick`. This can happen in tests that manually trigger `detectChanges` on the fixture, but there's also nothing stopping production code from calling `appRef.tick` either.
atscott
added
target: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…task scheduler
This commit updates the logic that switches the zoneless scheduler to a microtask scheduler from applying only when the scheduler runs to also when a change detection was scheduled but gets pre-empted by another call to
tick. This can happen in tests that manually triggerdetectChangeson the fixture, but there's also nothing stopping production code from callingappRef.tickeither.