fix(compiler-cli): symbol feature detection for the compiler #54711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the actual symbol presence in the .d.ts to detect whether two-way binding to writable signals should be template type-checked.
atscott
approved these changes
Mar 20, 2024
atscott
added
action: merge
|
This PR was merged into the repository by commit 6aff144. |
atscott
pushed a commit
that referenced
this pull request
Mar 20, 2024
Use the actual symbol presence in the .d.ts to detect whether two-way binding to writable signals should be template type-checked. PR Close #54711
atscott
added a commit
to atscott/angular
that referenced
this pull request
Mar 20, 2024
this test is failing after angular#54711
atscott
added a commit
that referenced
this pull request
Mar 20, 2024
atscott
added a commit
that referenced
this pull request
Mar 20, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the actual symbol presence in the .d.ts to detect whether two-way binding to writable signals should be template type-checked.