fix(ivy): ViewRef.rootNodes not including projected nodes #28951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if an embedded view contains projected nodes, its `rootNodes` array will include `null` instead of the root nodes inside the projection slot. This manifested itself in one of the Material unit tests where we stamp out a template and then move its `rootNodes` into the overlay container. This PR is related to FW-1087.
crisbeto
added
type: bug/fix
action: review
crisbeto
added a commit
to crisbeto/angular
that referenced
this pull request
Feb 24, 2019
Updates the root causes for the remaining `MatMenu` tests. Note that two tests are omitted from this PR, because one will be fixed by angular#28951 and the other one depends on static queries and will be refactored by angular/components#15289.
kara
added
action: presubmit
benlesh
pushed a commit
that referenced
this pull request
Feb 25, 2019
Updates the root causes for the remaining `MatMenu` tests. Note that two tests are omitted from this PR, because one will be fixed by #28951 and the other one depends on static queries and will be refactored by angular/components#15289. PR Close #28952
kara
added
action: merge
|
merge-assistance: core approval should be sufficient |
benlesh
added
target: patch
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if an embedded view contains projected nodes, its
rootNodesarray will includenullinstead of the root nodes inside the projection slot. This manifested itself in one of the Material unit tests where we stamp out a template and then move itsrootNodesinto the overlay container.This PR is related to FW-1087.