This repository was archived by the owner on Apr 12, 2024. It is now read-only.
refactor($location): remove unused arguments #9976
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You missed two lines, see #9482 ;) |
|
@realityking oh, right, in the spec. I was almost sure that I saw a PR for this refactoring already but couldn't find it! Going to close this one in favour of yours, thnx! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were number unused function arguments around appBase. Those got uncovered as soon as you realise that the
baseargument isn't used in theurlResolvefunction:angular.js/src/ng/urlUtils.js
Line 65 in 50e72fc