Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(guide/e2e-testing): fix outdated link to Protractor API #9946

Closed
wants to merge 1 commit into from
Closed

docs(guide/e2e-testing): fix outdated link to Protractor API #9946

wants to merge 1 commit into from

Conversation

AdirAmsalem
Copy link
Contributor

The link to Protractor API points to an outdated document, replaced it with the correct URL.

https://docs.angularjs.org/guide/e2e-testing -> Using Protractor -> "api docs" link.

@caitp
Copy link
Contributor

caitp commented Nov 6, 2014

looks good to me! i'm glad we're not reading markdown files anymore :D

@caitp
Copy link
Contributor

caitp commented Nov 6, 2014

there might be a few other protractor doc links in the tree, did you grep for them?

@caitp
Copy link
Contributor

caitp commented Nov 6, 2014

A quick search without your patch applied finds these:

docs/content//guide/e2e-testing.ngdoc:For more information on Protractor, view getting started
docs/content//guide/e2e-testing.ngdoc:or the api docs.
docs/content//tutorial/step_03.ngdoc:about the Protractor APIs at https://github.com/angular/protractor/blob/master/docs/api.md.
docs/content//tutorial/step_08.ngdoc:* Using the Protractor API,

caitp pushed a commit that referenced this pull request Nov 6, 2014
Link to the gh-pages deployment of protractor docs, it's much easier on the eyes.

Closes #9946
@caitp caitp closed this in 6550198 Nov 6, 2014
@AdirAmsalem
Copy link
Contributor Author

I will submit an additional PR for the tutorial fixes. You merged too fast :)

Edit: You've already did, thanks.

@caitp
Copy link
Contributor

caitp commented Nov 6, 2014

i included the other changes in the merge, its got your name on em it's all good

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants