Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Closes #9636 #9858

Closed
wants to merge 1 commit into from
Closed

Closes #9636 #9858

wants to merge 1 commit into from

Conversation

ryasmi
Copy link
Contributor

@ryasmi ryasmi commented Oct 31, 2014

I see no reason not to have this check. This PR is equivalent to #9636, just changes a little less.

No reason not to have this check.
@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@ryasmi
Copy link
Contributor Author

ryasmi commented Oct 31, 2014

Already signed it but with 0ryansmith1994@gmail.com.

On 31 October 2014 13:10, Mary Poppins notifications@github.com wrote:

I'm sorry, but I wasn't able to verify your Contributor License Agreement
(CLA) signature. CLA signature is required for any code contributions to
AngularJS.

Please sign our CLA
https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#signing-the-cla
and ensure that the CLA signature email address and the email address in
this PR's commits match
.

If you signed the CLA as a corporation, please let us know the company's
name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses
don't match. Please sign the CLA again or update the email address in the
commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA
verification process.


Reply to this email directly or view it on GitHub
#9858 (comment).

@ryasmi
Copy link
Contributor Author

ryasmi commented Oct 31, 2014

Google allows me to edit my recovery email but not add another one. I'm not
changing my recovery email or my Github email just to change a few
characters in your repo.

On 31 October 2014 13:14, Ryan Smith 0ryansmith1994@gmail.com wrote:

Already signed it but with 0ryansmith1994@gmail.com.

On 31 October 2014 13:10, Mary Poppins notifications@github.com wrote:

I'm sorry, but I wasn't able to verify your Contributor License Agreement
(CLA) signature. CLA signature is required for any code contributions to
AngularJS.

Please sign our CLA
https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#signing-the-cla
and ensure that the CLA signature email address and the email address
in this PR's commits match
.

If you signed the CLA as a corporation, please let us know the company's
name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email
addresses don't match. Please sign the CLA again or update the email
address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the
CLA verification process.


Reply to this email directly or view it on GitHub
#9858 (comment).

@caitp
Copy link
Contributor

caitp commented Oct 31, 2014

we should probably turn the robot off until she's working correctly again =) but fine, I guess this is okay, although if we're honest we'd probably want to abort resolveElementClasses before we got to this point, to prevent it from doing actual work in the highly unlikely case that this ever happened.

@caitp
Copy link
Contributor

caitp commented Oct 31, 2014

@matsko you can make the call on this

@matsko
Copy link
Contributor

matsko commented Oct 31, 2014

@caitp I think we should put it in even if there is no bug that reproduces it, it's a difficult regression to isolate.

@caitp
Copy link
Contributor

caitp commented Oct 31, 2014

merge when ready =)

@matsko
Copy link
Contributor

matsko commented Oct 31, 2014

MERGED as ed6e91b

@matsko matsko closed this Oct 31, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants